fix: non-generic id check in PostAsync #54
Conversation
| @@ -12,5 +12,10 @@ object IIdentifiable.Id | |||
| get { return Id; } | |||
| set { Id = (T)value; } | |||
| } | |||
|
|
|||
| public bool IsIdEmpty() | |||
There was a problem hiding this comment.
This will need to be virtual so users can override it. Also, since this won't work "out-of-the-box" for a lot of types. I'd like to add support for common, non-nullable types. I can work on this tonight.
|
@jfhs thanks for the PR! See my comments above. I can take it from here, or you can keep working on it if you want? |
|
@jaredcnance you are welcome :) However I've stumbled upon another problem, again related to Id type. I will describe it here, because I think solution for both problem is linked. I got Given that and problem for checking id for empty/null, maybe a better solution would be to have methods like Also, I hurried a bit with PR, probably it would break your samples (at least one from the video) because for I'm not sure I will be able to work any longer today, so if you want, you can just close my PR and do it yourself. If not, I will come back tomorrow, and fix it, because I need this working ASAP :) |
|
Closing in favor of #55 |
Proposed fix for #53